prk/issues

Fork 0

Buying items from a shop while inventory is full costs credits and doesn't give you your item #1026

New issue

Closed

opened 2024-09-30 02:43:15 +00:00 by Faffy-waffle · 5 comments

Faffy-waffle commented

2024-09-30 02:43:15 +00:00

(Migrated from github.com)

Reproduction steps

1. Fill your inventory until it is full
2. Take note of your credits. Buy an item from a shop terminal and click accept. The trade window bugs out and you have to manually close it. No item is added to your inventory or to overflow
3. Your credits will still be the same, but when you zone, you'll lose your credits depending on how much you 'spent'

Expected results

In live, when you attempt to buy items when your inventory is full, you should get an error saying "your inventory is full!" and the trade window closes. Credits should not be deducted upon zoning

Actual results

After attempting to buy items with a full inventory, credits disappeared upon zoning

Bug prevalence

Every time

Description

I tried buying a QL100 implant that costed 150k with a full inventory. I no longer have 150k :C

Report link

https://pastebin.com/Kb9y4Te3

### Reproduction steps ```bash 1. Fill your inventory until it is full 2. Take note of your credits. Buy an item from a shop terminal and click accept. The trade window bugs out and you have to manually close it. No item is added to your inventory or to overflow 3. Your credits will still be the same, but when you zone, you'll lose your credits depending on how much you 'spent' ``` ### Expected results ```bash In live, when you attempt to buy items when your inventory is full, you should get an error saying "your inventory is full!" and the trade window closes. Credits should not be deducted upon zoning ``` ### Actual results ```bash After attempting to buy items with a full inventory, credits disappeared upon zoning ``` ### Bug prevalence Every time ### Description ```bash I tried buying a QL100 implant that costed 150k with a full inventory. I no longer have 150k :C ``` ### Report link https://pastebin.com/Kb9y4Te3

kajoriEU commented

2024-09-30 08:26:37 +00:00

(Migrated from github.com)

Confirmed.

When buying items with a full inventory, the trade is canceled, but credits are deducted upon zoning.

https://github.com/user-attachments/assets/202b3055-cd15-4d71-8238-ace45552e719

Confirmed. When buying items with a full inventory, the trade is canceled, but credits are deducted upon zoning. https://github.com/user-attachments/assets/202b3055-cd15-4d71-8238-ace45552e719

kajori added this to the Season 2 Launch project 2024-11-25 15:07:41 +00:00

drake added the

area

trading

label 2024-12-19 17:57:40 +00:00

drake self-assigned this 2024-12-19 18:41:23 +00:00

drake added the

state

fixed

label 2024-12-19 20:21:36 +00:00

drake commented

2024-12-19 20:21:42 +00:00

This should now be fixed

Raggy commented

2024-12-19 20:46:49 +00:00

Member

Sort of 'fixed'. Instead of just cancelling the trade, the terminal will now just dump all purchases into your overflow window. Definitely not Live behaviour though. Will update the label.

*Sort of* 'fixed'. Instead of just cancelling the trade, the terminal will now just dump all purchases into your overflow window. Definitely not Live behaviour though. Will update the label. ![image](/attachments/285417d1-962b-4b17-a64e-599340206661)

image.png

251 KiB

Raggy removed the

state

fixed

label 2024-12-19 20:46:59 +00:00

drake added the

state

fixed

label 2024-12-20 11:26:46 +00:00

drake commented

2024-12-20 11:27:42 +00:00

I've changed this to work the same way as it does on live now.

Raggy commented

2024-12-22 15:15:36 +00:00

Member

Confirmed, inventory now only fills to the amount of possible spaces and then outputs the Your inventory is full! system message, also only bills you for the amounts relating to the number of purchased items. 100% live behaviour. Closing as fixed as of 22/12/24.

Confirmed, inventory now only fills to the amount of possible spaces and then outputs the `Your inventory is full!` system message, also only bills you for the amounts relating to the number of purchased items. 100% live behaviour. Closing as fixed as of 22/12/24.

Raggy closed this issue

2024-12-22 15:15:36 +00:00

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: prk/issues#1026

No description provided.

Rows
Columns