prk/issues
12
3
Fork 0
Code Issues 227 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Buying items from a shop while inventory is full costs credits and doesn't give you your item #1026

New Issue
Closed
opened 2024-09-30 04:43:15 +02:00 by Faffy-waffle · 5 comments
Faffy-waffle commented 2024-09-30 04:43:15 +02:00 (Migrated from github.com)
Copy Link

Reproduction steps

1. Fill your inventory until it is full
2. Take note of your credits. Buy an item from a shop terminal and click accept. The trade window bugs out and you have to manually close it. No item is added to your inventory or to overflow
3. Your credits will still be the same, but when you zone, you'll lose your credits depending on how much you 'spent'

Expected results

In live, when you attempt to buy items when your inventory is full, you should get an error saying "your inventory is full!" and the trade window closes. Credits should not be deducted upon zoning

Actual results

After attempting to buy items with a full inventory, credits disappeared upon zoning

Bug prevalence

Every time

Description

I tried buying a QL100 implant that costed 150k with a full inventory. I no longer have 150k :C

Report link

https://pastebin.com/Kb9y4Te3

### Reproduction steps ```bash 1. Fill your inventory until it is full 2. Take note of your credits. Buy an item from a shop terminal and click accept. The trade window bugs out and you have to manually close it. No item is added to your inventory or to overflow 3. Your credits will still be the same, but when you zone, you'll lose your credits depending on how much you 'spent' ``` ### Expected results ```bash In live, when you attempt to buy items when your inventory is full, you should get an error saying "your inventory is full!" and the trade window closes. Credits should not be deducted upon zoning ``` ### Actual results ```bash After attempting to buy items with a full inventory, credits disappeared upon zoning ``` ### Bug prevalence Every time ### Description ```bash I tried buying a QL100 implant that costed 150k with a full inventory. I no longer have 150k :C ``` ### Report link https://pastebin.com/Kb9y4Te3
kajoriEU commented 2024-09-30 10:26:37 +02:00 (Migrated from github.com)
Copy Link

Confirmed.

When buying items with a full inventory, the trade is canceled, but credits are deducted upon zoning.

https://github.com/user-attachments/assets/202b3055-cd15-4d71-8238-ace45552e719

Confirmed. When buying items with a full inventory, the trade is canceled, but credits are deducted upon zoning. https://github.com/user-attachments/assets/202b3055-cd15-4d71-8238-ace45552e719
kajori added this to the Season 2 Launch project 2024-11-25 16:07:41 +01:00
drake added the
area
trading
 label 2024-12-19 18:57:40 +01:00
drake self-assigned this 2024-12-19 19:41:23 +01:00
drake added the
state
fixed
 label 2024-12-19 21:21:36 +01:00
drake commented 2024-12-19 21:21:42 +01:00
Copy Link

This should now be fixed

This should now be fixed
Raggy commented 2024-12-19 21:46:49 +01:00
Member
Copy Link

Sort of 'fixed'. Instead of just cancelling the trade, the terminal will now just dump all purchases into your overflow window. Definitely not Live behaviour though. Will update the label.

image

*Sort of* 'fixed'. Instead of just cancelling the trade, the terminal will now just dump all purchases into your overflow window. Definitely not Live behaviour though. Will update the label. ![image](/attachments/285417d1-962b-4b17-a64e-599340206661)
image.png
251 KiB
Raggy removed the
state
fixed
 label 2024-12-19 21:46:59 +01:00
drake added the
state
fixed
 label 2024-12-20 12:26:46 +01:00
drake commented 2024-12-20 12:27:42 +01:00
Copy Link

I've changed this to work the same way as it does on live now.

I've changed this to work the same way as it does on live now.
Raggy commented 2024-12-22 16:15:36 +01:00
Member
Copy Link

Confirmed, inventory now only fills to the amount of possible spaces and then outputs the Your inventory is full! system message, also only bills you for the amounts relating to the number of purchased items. 100% live behaviour. Closing as fixed as of 22/12/24.

Confirmed, inventory now only fills to the amount of possible spaces and then outputs the `Your inventory is full!` system message, also only bills you for the amounts relating to the number of purchased items. 100% live behaviour. Closing as fixed as of 22/12/24.
Raggy closed this issue 2024-12-22 16:15:36 +01:00
kajori moved this to Done in Season 2 Launch on 2025-01-10 06:24:23 +01:00
kajori moved this to Done in Season 2 Launch on 2025-01-10 06:24:36 +01:00
drake moved this to Done in Season 2 Launch on 2025-01-13 03:05:06 +01:00
drake moved this to Done in Season 2 Launch on 2025-01-13 03:05:06 +01:00
kajori moved this to Done in Season 2 Launch on 2025-01-13 07:07:43 +01:00
kajori moved this to Done in Season 2 Launch on 2025-01-16 11:55:30 +01:00
kajori moved this to Done in Season 2 Launch on 2025-01-16 11:56:22 +01:00
kajori moved this to Done in Season 2 Launch on 2025-01-16 12:15:35 +01:00
kajori moved this to Done in Season 2 Launch on 2025-01-16 12:48:06 +01:00
drake moved this to Done in Season 2 Launch on 2025-01-17 08:04:39 +01:00
drake moved this to Done in Season 2 Launch on 2025-01-17 08:04:41 +01:00
kajori moved this to Done in Season 2 Launch on 2025-01-17 08:23:53 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area
blabot
Related to NPC dialog/conversations
area
client
This issue is (or appears to be) client-side
area
encounters
Related to scripted encounters
area
launcher
Related to the launcher
area
missions
Related to randomly generated missions
area
npc-behavior
Related to NPC/monster behaviour
area
performance
Caused by or related to server performance issues
area
portal
Related to the player portal website
area
quests
Issues relating to quests
area
rdb
Caused by RDB issues
area
teams
Issues relating to teaming with other players
area
trading
Related to trading with vendors and/or other players
priority
1
Crashes playfield/server/other players or is game-breaking in a major way
priority
2
Crashes/breaks a character, significant gameplay impact with no workaround
priority
3
Standard or significant gameplay impact with workaround
priority
4
Trivial or minor gameplay impact, with or without workaround, or visual only
shadowlands
Related only to Shadowlands content
state
cant-reproduce
Can't be recreated by another tester
state
duplicate
This issue or pull request already exists
state
fixed
Developer has rolled out changes, needs re-tested to confirm fixed
state
new
Needs to be (re-)tested to ensure the issue is reproducible
state
unrefined
Needs more detail, repro steps or to be cleaned up
state
wontfix
This will not be worked on
type
bug
An implemented feature is not working correctly
type
enhancement
Unimplemented feature, new feature / request
No Label
area
trading
priority
3
state
fixed
type
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project Season 2 Launch
Assignees
Clear assignees
No Assignees drake
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: prk/issues#1026
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?