Bureaucrat's charmed pets actions and damage does not show on "Your pets" chat channel #1111

Closed
opened 2024-10-14 06:11:13 +00:00 by ZakMcKracken · 4 comments

https://bytebin.project-rk.com/qLXQV0b1

Reproduction steps

  1. Charm pet
  2. Give charmed pet command (example: Attack, Follow, Wait)

Expected results

Charmed pet's actions and damage should appear on "Your pets" chat channel.

Actual results

Charmed pet's actions and damage do not appear on "Your pets" chat channel.
But Charmed pet's damage does show on "Other hit by other" channel.

Bug prevalence

Everytime I give charmed pet a command.

Description & Attachments

Charmed pets action should show on "Your pets" chat channel. Now they don't show at all.
Also currently Charmed pet's damage does show on "Other hit by other" channel, but it should be in "Your pets" chat channel.

Below is example of charmed Eleet's messages that should display on "Your pets" chat channel (But currently they do not show at all):

Charm Eleet and "Your pets" channel should display message:
Megalomania's pet, Eleet: I am now loyal to you. I will do as you say...
Command Attack, should display message:
Megalomania's pet, Eleet: I will try to kill it, master!
Command Wait, should display message:
Megalomania's pet, Eleet: OK. I'll wait!
Command Follow, should display message:
Megalomania's pet, Eleet: I will follow you, master.
### Report link https://bytebin.project-rk.com/qLXQV0b1 ### Reproduction steps 1. Charm pet 2. Give charmed pet command (example: Attack, Follow, Wait) ### Expected results Charmed pet's actions and damage should appear on "Your pets" chat channel. ### Actual results Charmed pet's actions and damage do not appear on "Your pets" chat channel. But Charmed pet's damage does show on "Other hit by other" channel. ### Bug prevalence Everytime I give charmed pet a command. ### Description & Attachments Charmed pets action should show on "Your pets" chat channel. Now they don't show at all. Also currently Charmed pet's damage does show on "Other hit by other" channel, but it should be in "Your pets" chat channel. Below is example of charmed Eleet's messages that should display on "Your pets" chat channel (But currently they do not show at all): Charm Eleet and "Your pets" channel should display message: : Megalomania's pet, Eleet: I am now loyal to you. I will do as you say... Command Attack, should display message: : Megalomania's pet, Eleet: I will try to kill it, master! Command Wait, should display message: : Megalomania's pet, Eleet: OK. I'll wait! Command Follow, should display message: : Megalomania's pet, Eleet: I will follow you, master.
Owner

I believe that we have not yet implemented the blabot for charmed pet. When a monster is charmed, we need to change their blabot ID to the ID for charmed pet. When the charm ends (e.g. through /pet free, then the monster's original blabot needs to be restored.

I believe that we have not yet implemented the blabot for charmed pet. When a monster is charmed, we need to change their blabot ID to the ID for charmed pet. When the charm ends (e.g. through `/pet free`, then the monster's original blabot needs to be restored.
Member

Confirmed that charmed pet damage does not show in pet channel, and only in 'other hit by other' channel.

Confirmed that charmed pet damage does not show in pet channel, and only in 'other hit by other' channel.
Member

This is now fixed on Ergo.

This is now fixed on Ergo.
Member

image

CLosed all the "other X" channels in combat chat and can view my charmed pet's damage.

![image](/attachments/faafc20a-1ea8-4a23-ba41-4ef0e5e4b93d) CLosed all the "other X" channels in combat chat and can view my charmed pet's damage.
Sign in to join this conversation.
No milestone
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prk/issues#1111
No description provided.