Launcher Bug: Client Directory Resets to Default After Saving and Restarting on Windows 10/11 #1203

New issue

Open

opened 2024-12-15 20:24:52 +00:00 by CookieMonster · 0 comments

CookieMonster commented

2024-12-15 20:24:52 +00:00

Describe the bug
When changing the client directory from the default (C:\prk\client\client) to a custom folder, the launcher appears to save the change successfully. However, upon reopening the settings or relaunching the game, the client directory resets back to the default path, causing the launcher to prompt for a re-download of the client files.

Additionally, if you change the client directory but switch to another tab (e.g., Display or GUI) before clicking Save, only the settings of the active tab are saved. The changes made in the previous tab (e.g., the client directory) are not saved. This behavior is confusing because clicking Save causes the settings modal to close, giving the impression that all changes across all tabs have been saved.

If you click Save while still on the Launcher tab (without switching tabs), the client directory will be saved correctly.

Related: #538

To Reproduce
Steps to reproduce the behavior:

Open the launcher on Windows 10/11.
Navigate to Settings > Launcher tab.
Change the Client Directory from the default path (C:\prk\client\client) to a different folder.
Switch to the Display or GUI tab without clicking Save.
Make changes to settings in the Display or GUI tab.
Click Save — notice that the settings modal closes as expected.
Reopen Settings and go to the Launcher tab — notice that the client directory has reverted back to C:\prk\client\client.

Expected behavior
When the user clicks Save, all settings across all tabs should be saved, not just the active tab. Alternatively, the system should warn the user that unsaved changes exist before allowing them to switch tabs. This would prevent confusion and ensure that users understand their changes are not being saved.

Screenshots
If applicable, add screenshots to help explain your problem.

**Describe the bug** When changing the client directory from the default (`C:\prk\client\client`) to a custom folder, the launcher appears to save the change successfully. However, upon reopening the settings or relaunching the game, the client directory resets back to the default path, causing the launcher to prompt for a re-download of the client files. Additionally, if you change the client directory but switch to another tab (e.g., **Display** or **GUI**) before clicking **Save**, only the settings of the **active tab** are saved. The changes made in the previous tab (e.g., the client directory) are not saved. This behavior is confusing because clicking **Save** causes the settings modal to close, giving the impression that all changes across all tabs have been saved. If you **click Save** while still on the **Launcher** tab (without switching tabs), the client directory will be saved correctly. > **Related:** #538 **To Reproduce** Steps to reproduce the behavior: 1. Open the launcher on Windows 10/11. 2. Navigate to **Settings** > **Launcher** tab. 3. Change the **Client Directory** from the default path (`C:\prk\client\client`) to a different folder. 4. **Switch to the Display or GUI tab without clicking Save.** 5. Make changes to settings in the **Display** or **GUI** tab. 6. Click **Save** — notice that the settings modal closes as expected. 7. Reopen **Settings** and go to the **Launcher** tab — notice that the client directory has reverted back to `C:\prk\client\client`. **Expected behavior** When the user clicks **Save**, all settings across **all tabs** should be saved, not just the active tab. Alternatively, the system should warn the user that unsaved changes exist before allowing them to switch tabs. This would prevent confusion and ensure that users understand their changes are not being saved. **Screenshots** If applicable, add screenshots to help explain your problem. <!-- **Character info:**