prk/issues
8
1
Fork 0
Code Issues 250 Pull Requests Actions Packages Projects Releases Wiki Activity

Characters who warped to an invalid playfield are completely inaccessible #315

New Issue
Closed
opened 2023-11-22 22:13:27 +01:00 by abc · 2 comments
abc commented 2023-11-22 22:13:27 +01:00 (Migrated from github.com)
Copy Link

Describe the bug
If you use the /tp command to teleport to an invalid playfield, the command executes, but the game crashes, because the playfield does not exist. Any time you connect to the character from that point on, the game will always crash.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new character.
  2. Use the tp command to go to an invalid playfield, e.g. /tp 1337 1 1
  3. The game will crash, and the character will be inaccessible.

Expected behavior
There should be some graceful handling of wrong warps, e.g. if a character ends up in an invalid playfield, they should be warped into the grid as a zone of last resort.

**Describe the bug** If you use the /tp command to teleport to an invalid playfield, the command executes, but the game crashes, because the playfield does not exist. Any time you connect to the character from that point on, the game will always crash. **To Reproduce** Steps to reproduce the behavior: 1. Create a new character. 2. Use the tp command to go to an invalid playfield, e.g. `/tp 1337 1 1` 3. The game will crash, and the character will be inaccessible. **Expected behavior** There should be some graceful handling of wrong warps, e.g. if a character ends up in an invalid playfield, they should be warped into the grid as a zone of last resort.
abc commented 2023-11-26 13:07:50 +01:00 (Migrated from github.com)
Copy Link

Fixed by 752b11e915

Fixed by https://github.com/project-rubika/engines/commit/752b11e915fdf9d0a294c09eacf920d4ecd1b503
abc commented 2023-12-05 00:48:01 +01:00 (Migrated from github.com)
Copy Link

Confirmed fixed.

Confirmed fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
area
blabot
Related to NPC dialog/conversations

  
area
client
This issue is (or appears to be) client-side

  
area
encounters
Related to scripted encounters

  
area
launcher
Related to the launcher

  
area
missions
Related to randomly generated missions

  
area
npc-behavior
Related to NPC/monster behaviour

  
area
performance
Caused by or related to server performance issues

  
area
portal
Related to the player portal website

  
area
rdb
Caused by RDB issues

  
priority
1
Crashes playfield/server/other players or is game-breaking in a major way

  
priority
2
Crashes/breaks a character, significant gameplay impact with no workaround

  
priority
3
Standard or significant gameplay impact with workaround

  
priority
4
Trivial or minor gameplay impact, with or without workaround, or visual only

  
shadowlands

Related only to Shadowlands content

  
state
cant-reproduce
Can't be recreated by another tester

  
state
duplicate
This issue or pull request already exists

  
state
fixed
Developer has rolled out changes, needs re-tested to confirm fixed

  
state
new
Needs to be (re-)tested to ensure the issue is reproducible

  
state
unrefined
Needs more detail, repro steps or to be cleaned up

  
state
wontfix
This will not be worked on

  
type
bug
An implemented feature is not working correctly

  
type
enhancement
Unimplemented feature, new feature / request

No Label
area
blabot
area
client
area
encounters
area
launcher
area
missions
area
npc-behavior
area
performance
area
portal
area
rdb
priority
1
priority
2
priority
3
priority
4
shadowlands
state
cant-reproduce
state
duplicate
state
fixed
state
new
state
unrefined
state
wontfix
type
bug
type
enhancement
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: prk/issues#315
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?