Using the Atrox (46238) item crashes clients (incl. vincinity) #398

Open
opened 2023-12-29 04:13:19 +01:00 by deathlef · 7 comments
deathlef commented 2023-12-29 04:13:19 +01:00 (Migrated from github.com)

Describe the bug
Using the Atrox item (46238) crashes the client

To Reproduce
Steps to reproduce the behavior:

  1. Spawn item /item 46238 46238 1
  2. Use item
  3. Crash ;-)

Expected behavior
To be changed into an Atrox without crashing, including other nearby players.

Playfield info:
Extended location information:

  • 408.9, 310.7, 25.5 (408.9 310.7 y 25.5 566)
  • Pf Proxy: Model=51100:566 GS=0 SG=0 R=566, resource: 566
  • zone: 115, area: "Newland City"
    Server id: 1, character id: 50000:434, time: 2023-12-29 03:12:52 (UTC)
    Version: 00.3.6_EP1, map id: NOT FOUND, build: 52606.

**Describe the bug** Using the Atrox item (46238) crashes the client **To Reproduce** Steps to reproduce the behavior: 1. Spawn item /item 46238 46238 1 2. Use item 3. Crash ;-) **Expected behavior** To be changed into an Atrox without crashing, including other nearby players. **Playfield info:** Extended location information: - 408.9, 310.7, 25.5 (408.9 310.7 y 25.5 566) - Pf Proxy: Model=51100:566 GS=0 SG=0 R=566, resource: 566 - zone: 115, area: "Newland City" Server id: 1, character id: 50000:434, time: 2023-12-29 03:12:52 (UTC) Version: 00.3.6_EP1, map id: NOT FOUND, build: 52606. ----
prkdrake commented 2024-01-06 05:39:14 +01:00 (Migrated from github.com)

Is this an item which should actually be used from the inventory, or a dynel which should be placed in the world, like the buttons in the old character creation playfield/Parnassos?

Pretty minor, either way, considering this is unlikely to happen in regular play

Is this an item which should actually be used from the inventory, or a dynel which should be placed in the world, like the buttons in the old character creation playfield/Parnassos? Pretty minor, either way, considering this is unlikely to happen in regular play
deathlef commented 2024-01-07 13:54:52 +01:00 (Migrated from github.com)

Im not sure where or how the item is to be used in normal circumstances. Only reason that this is reported as it causes player (other than the user) to be disconnected. Perhaps its worth considering adding items that cause crashes to a denylist in order to avoid players crashing another when using such items.

Im not sure where or how the item is to be used in normal circumstances. Only reason that this is reported as it causes player (other than the user) to be disconnected. Perhaps its worth considering adding items that cause crashes to a denylist in order to avoid players crashing another when using such items.
TheTinkeringIdiot commented 2024-01-28 19:39:54 +01:00 (Migrated from github.com)

Confirmed.

Using this item indeed crashes the client that used it along with other clients in the vicinity. Upon logging back in, the character that used the item has the body of an Atrox but retains their original head. Other characters in t he vicinity that also crashed are not affected by the Atrox change.

Using the similar Solitus Female item (/item 46243 46243 1) also crashes the using client and all nearby clients. It may have also caused a playfield crash as attempting to log in immediately after resulted in several minutes of "Server Error" at the login screen.

Bumping to priority 1 until it can be confirmed that this isn't causing a backend crash along with the clients.

These items can only be obtained by GMs with access to the item command, and it's not clear whether this item was ever intended to exist in an inventory (vs being used in some background process during character creation or shape changing).

image

image

Confirmed. Using this item indeed crashes the client that used it along with other clients in the vicinity. Upon logging back in, the character that used the item has the body of an Atrox but retains their original head. Other characters in t he vicinity that also crashed are not affected by the Atrox change. Using the similar Solitus Female item (`/item 46243 46243 1`) also crashes the using client and all nearby clients. It may have also caused a playfield crash as attempting to log in immediately after resulted in several minutes of "Server Error" at the login screen. Bumping to priority 1 until it can be confirmed that this isn't causing a backend crash along with the clients. These items can only be obtained by GMs with access to the item command, and it's not clear whether this item was ever intended to exist in an inventory (vs being used in some background process during character creation or shape changing). ![image](https://github.com/project-rubika/issues/assets/96996793/0d14cd2e-0a99-48ea-bf6f-9a27e35eb1e3) ![image](https://github.com/project-rubika/issues/assets/96996793/2f33a200-5593-4db5-b458-94a57c92f0a3)
prkdrake commented 2024-02-01 01:05:52 +01:00 (Migrated from github.com)

It's the template action message broadcast which is causing crashes, I suspect because the item is invalid, investigating further - if nothing else, item creation should fail

It's the template action message broadcast which is causing crashes, I suspect because the item is invalid, investigating further - if nothing else, item creation should fail
prkdrake commented 2024-02-01 01:16:32 +01:00 (Migrated from github.com)

Item is a dynel, only reason it's spawning is because we have an NPC in our database which just so happens to share instance IDs. Item spawning should fail. To fix, prevent creation of template type 70002 with item creation tools at very least.

Item is a dynel, only reason it's spawning is because we have an NPC in our database which just so happens to share instance IDs. Item spawning should fail. To fix, prevent creation of template type 70002 with item creation tools at very least.
JulianVallee commented 2024-04-10 03:11:47 +02:00 (Migrated from github.com)

Most likely parnassos as you already said, just happened to be around there and was struck by the 1 to 1 similarity
image

Doesn't seem to do anything, Only takes effect after zoning, but at least also doesn't crash the client here :D
image

Most likely parnassos as you already said, just happened to be around there and was struck by the 1 to 1 similarity ![image](https://github.com/project-rubika/issues/assets/6720458/c31916c9-9fda-4cf1-a3f7-059ca070889e) ~~Doesn't seem to do anything~~, Only takes effect after zoning, but at least also doesn't crash the client here :D ![image](https://github.com/project-rubika/issues/assets/6720458/5a7e29cb-bd2e-4ee9-a6a9-58175b52db78)
Unknownprk commented 2024-06-27 18:02:51 +02:00 (Migrated from github.com)

changing this to low priority as it's only possible through a spawned item

changing this to low priority as it's only possible through a spawned item
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: prk/issues#398
No description provided.