The 'Trader Debuff AC Nanos' debuff line does not apply the higher debuff. #582
Labels
No labels
area
blabot
area
client
area
encounters
area
launcher
area
missions
area
npc-behavior
area
performance
area
portal
area
quests
area
rdb
area
teams
area
trading
area
zone
priority
1
priority
2
priority
3
priority
4
shadowlands
state
cant-reproduce
state
duplicate
state
fixed
state
new
state
unrefined
state
verified
state
wontfix
type
bug
type
enhancement
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: prk/issues#582
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe the bug
The 'Abolish' line of nanos 'Trader Debuff AC Nanos' do not check for the higher ACs when the debuff applies. Tested at both 0 AC and setting mob AC to 30000
To Reproduce
Steps to reproduce the behavior:
.getfull
to check current AC..set meleeac 30000
.getfull
.Expected behavior
The debuff should be stronger or weaker based on the AC for the target.
Screenshots

Character info:
Confirmed.
Abolish Polonium, top in this nano line, applies only it's lowest AC debuff (-2778) despite the target meeting the requirements for a much stronger debuff.
This is a really tricky one to nail down properly.
So in Auno, you will see that the "function target" is shown as "Target".. but the in game UI shows it at OnTarget -> OnSelf. So basically OnTarget will execute the nano from the target's NCU.. and when it executes.. it needs to resolve "OnSelf" as the target.. not the caster. In our case "OnSelf" was resolving as the caster, resulting in NPCFamily == 0 to be true.
So tricky... but the change was simple. @RaggyLP you will need to ensure that this change however doesn't impact other buffs.
I did a quick check on Health Funnel ( a common function targeting pain point) and that worked.
You might want to try testing some additional strange targeting configurations like Mongo Slam, Crat auras etc. I'm concerned my change here will break those scenarios.. but perhaps im just fearful :-)
Please test and let me know.
Re-tested, nano still appears to be using the NPC Target 0 modifiers.
Retested again, it is now working as expected, a futher issue has reared its head in the fact there is discrepancies on NPCFamily type for some NPCs (those spawned in the BY for example are listed as 0).
Npc Family issues should be resolved
Nanoline confirmed to be working now when used on a mob with the correct NPCFamily. Fixed as of 21:37 UTC - 19/02/24