prk/issues
20
3
Fork 0
Code Issues 242 Pull requests Projects 2 Releases Packages Wiki Activity Actions

Over-equipped (OE) is currently not implemented. #584

New issue
Closed
opened 2024-01-30 22:47:57 +00:00 by RaggyLP · 5 comments
RaggyLP commented 2024-01-30 22:47:57 +00:00 (Migrated from github.com)
Copy link

Describe the bug
When an item is equipped, but the requirements to wear said item are not met, the item is not entering the Over-Equipped state.

To Reproduce
Steps to reproduce the behavior:

  1. Equip an item.
  2. Do a .getfull for your choice of modifier.
  3. Use .set to reduce a skill it relies on to be equipped.
  4. Check to ese how much the item is 'OE' by.
  5. Do another .getfull to confirm no modifier change on the server.

Expected behavior
When an item enters the OE sate, certain modifiers should be reduced.
More details here: https://www.ao-universe.com/guides/classic-ao/gameplay-guides-6/over-equipped

Screenshots
image

Character info:

Raggy [220 Trader]
------------------------------------
    pharmaceuticals 	562
    nanoprogramming 	578
    psychology 	593
    chemistry 	579
    tutoring 	581
    materialmetamorphose 	570
    firstaid 	485
    concealment 	537
    breakingentry 	283
    disarmtrap 	364
    perception 	562
    driveair 	556
    driveground 	556
    drivewater 	556
    mapnavigation 	546
    maxnanoenergy 	4966
    side 	1
    selectedtargettype 	0
    charstate 	0
    exitstatel 	-1073740870
    externaldoorinstance 	0
    externalplayfieldinstance 	0
    playfieldtype 	0
    isfightingme 	0
    life 	7005
    waitstate 	1
    bodydevelopment 	1295
    expansionplayfield 	0
    secondaryitemtemplate 	207108
    specialization 	15
    level 	220
    sex 	2
    visualsex 	2
    titlelevel 	7
    health 	7106
    equippedweapontype 	8196
    EquippedRHWeapon 	8196
    selectedtarget 	1028
    nextxp 	3067008
    xp 	2555840
    lastsaved 	2555840
    treatment 	2671
    lastxp 	2555840
    currentncu 	0
    runspeed 	1532
    senseimprovement 	604
    strength 	834
    stamina 	1421
    agility 	1083
    sense 	1010
    psychic 	149
    intelligence 	1415
    flags 	528961
    monsterscale 	100
    currentnano 	8885
    headmesh 	223891
    cash 	21883
    gmlevel 	127
    expansion 	3
    breed 	2
    visualbreed 	2
    profession 	7
    visualprofession 	7
    piercing 	371
    twohandbluntweapons 	286
    twohandedgedweapons 	272
    meleeenergyweapon 	359
    parry 	322
    sneakattack 	297
    meleemultiple 	265
    fastattack 	268
    throwingknife 	337
    grenade 	477
    throwngrapplingweapons 	437
    bow 	256
    pistol 	543
    assaultrifle 	519
    submachinegun 	500
    rifle 	268
    lr_energyweapon 	191
    flingshot 	550
    aimedshot 	312
    burst 	328
    fullauto 	464
    bowspecialattack 	345
    lr_multipleweapon 	1304
    closecombatinitiative 	226
    physicalprowessinitiative 	226
    dodge 	1388
    evade 	1496
    duck 	597
    nanoac 	280
    mechanicalengineering 	537
    electricalengineering 	554
    fieldquantumphysics 	420
    weaponsmithing 	641
    biologicalmetamorphose 	570
    psychologicalmodification 	613
    materialcreation 	1631
    materiallocation 	1613
    nanoprowessinitiative 	539
    shotgun 	50
    distanceweaponinitiative 	281
    computerliteracy 	1568
    nanoenergypool 	850
    martialarts 	193
    brawl 	272
    riposte 	266
    dimach 	214
    adventuring 	425
    swim 	501
    onehandbluntweapons 	278
    onehandedgedweapon 	282
    maxncu 	91
    fatness 	1
    race 	1
    accountflags 	1234567890
    monsterdata 	0
    VisualFlags 	31
    currentmovementmode 	3
    clan 	0
    healdelta 	155
    nanodelta 	112
    procnano1 	210941
    procinitiative1 	4
    procchance1 	17
    team 	0
    meleeac 	1000
    projectileac 	1250
    energyac 	1500
    fireac 	1956
    coldac 	1933
    radiationac 	2183
    chemicalac 	1683
    poisonac 	1250
    dmsmodifier 	343
    amsmodifier 	21
    rangeincreaserweapon 	7
    rangeincreasernf 	31
    firedamagemodifier 	19
    poisondamagemodifier 	19
    projectiledamagemodifier 	19
    radiationdamagemodifier 	19
    chemicaldamagemodifier 	19
    xpmodifier 	9
    npcostmodifier 	-8
    skilllockmodifier 	-25
    interruptmodifier 	-25
    aggdef 	100
    state 	0
    unarmedtemplateinstance 	0
    invaderskilled 	0
    killedbyinvaders 	0
    vp 	0
    unsavedxp 	0
    nanofocuslevel 	0
    shadowbreedtemplate 	0
    shadowbreed 	0
    lastperkresettime 	0
    socialstatus 	0
    playeroptions 	0
    tempsaveteamid 	0
    tempsaveplayfield 	0
    tempsavex 	0
    tempsavey 	0
    PVPDuelKills 	0
    PVPDuelDeaths 	0
    PVPProfessionDuelKills 	0
    PVPProfessionDuelDeaths 	0
    PVPRankedSoloKills 	0
    PVPRankedSoloDeaths 	0
    PVPRankedTeamKills 	0
    PVPRankedTeamDeaths 	0
    PVPSoloScore 	0
    PVPTeamScore 	0
    PVPDuelScore 	0
    unreadmailcount 	0
    lastmailchecktime 	1283065897
    savedxp 	0
    features 	6
    apartmentsallowed 	1
    apartmentsowned 	0
    lastconcreteplayfieldinstance 	0
    mapoptions 	0
    mapareapart1 	0
    mapareapart2 	0
    mapareapart3 	0
    mapareapart4 	0
    missionbits1 	0
    missionbits2 	0
    missionbits3 	0
    missionbits4 	0
    missionbits5 	0
    missionbits6 	0
    missionbits7 	0
    missionbits8 	0
    missionbits9 	0
    missionbits10 	0
    missionbits11 	0
    missionbits12 	0
    sessiontime 	1234567890
    autoattackflags 	5
    personalresearchlevel 	0
    globalresearchlevel 	0
    personalresearchgoal 	0
    globalresearchgoal 	0
    battlestationside 	0
    battlestationrep 	10
    members 	999
    veteranpoints 	0
    monthspaid 	0
    PaidPoints 	0
    xpkillrange 	5
    inplay 	0
    attitude 	0
    alignment 	0
    icon 	0
    mesh 	17530
    deadtimer 	0
    lastsavexp 	0
    currentmass 	0
    itemtype 	0
    previoushealth 	50
    currentstate 	0
    age 	0
    attackspeed 	5
    metatype 	0
    rp 	0
    specialcondition 	1
    sk 	0
    clanredeemed 	0
    clanconserver 	0
    clandevoted 	0
    otunredeemed 	0
    otoperator 	0
    otfollowers 	0
    gos 	0
    clanvanguards 	0
    ottrans 	0
    clangaia 	0
    otmed 	1234567890
    clansentinels 	0
    otarmedforces 	0
    playerid 	1234567890
    alienlevel 	0
    aliennextxp 	1500
    alienxp 	0
    insurancepercentage 	0
    prevmovementmode 	3
    teamside 	0
    beltslots 	0
    absorbprojectileac 	0
    absorbmeleeac 	0
    absorbenergyac 	0
    absorbchemicalac 	0
    absorbradiationac 	0
    absorbcoldac 	0
    absorbnanoac 	0
    absorbfireac 	0
    absorbpoisonac 	0
    temporaryskillreduction 	0
    insurancetime 	0
    mapflags 	0
    changesidecount 	0
    healinterval 	1
    nanointerval 	24
------------------------------------

.getfull succeeded - Listed all stats for Raggy.
**Describe the bug** When an item is equipped, but the requirements to wear said item are not met, the item is not entering the Over-Equipped state. **To Reproduce** Steps to reproduce the behavior: 1. Equip an item. 2. Do a ```.getfull``` for your choice of modifier. 3. Use ```.set``` to reduce a skill it relies on to be equipped. 4. Check to ese how much the item is 'OE' by. 5. Do another ```.getfull``` to confirm no modifier change on the server. **Expected behavior** When an item enters the OE sate, certain modifiers should be reduced. More details here: https://www.ao-universe.com/guides/classic-ao/gameplay-guides-6/over-equipped **Screenshots** ![image](https://github.com/project-rubika/issues/assets/156821187/6e12527d-9e10-4ad3-80eb-3fd33425aa36) **Character info:** ``` Raggy [220 Trader] ------------------------------------ pharmaceuticals 562 nanoprogramming 578 psychology 593 chemistry 579 tutoring 581 materialmetamorphose 570 firstaid 485 concealment 537 breakingentry 283 disarmtrap 364 perception 562 driveair 556 driveground 556 drivewater 556 mapnavigation 546 maxnanoenergy 4966 side 1 selectedtargettype 0 charstate 0 exitstatel -1073740870 externaldoorinstance 0 externalplayfieldinstance 0 playfieldtype 0 isfightingme 0 life 7005 waitstate 1 bodydevelopment 1295 expansionplayfield 0 secondaryitemtemplate 207108 specialization 15 level 220 sex 2 visualsex 2 titlelevel 7 health 7106 equippedweapontype 8196 EquippedRHWeapon 8196 selectedtarget 1028 nextxp 3067008 xp 2555840 lastsaved 2555840 treatment 2671 lastxp 2555840 currentncu 0 runspeed 1532 senseimprovement 604 strength 834 stamina 1421 agility 1083 sense 1010 psychic 149 intelligence 1415 flags 528961 monsterscale 100 currentnano 8885 headmesh 223891 cash 21883 gmlevel 127 expansion 3 breed 2 visualbreed 2 profession 7 visualprofession 7 piercing 371 twohandbluntweapons 286 twohandedgedweapons 272 meleeenergyweapon 359 parry 322 sneakattack 297 meleemultiple 265 fastattack 268 throwingknife 337 grenade 477 throwngrapplingweapons 437 bow 256 pistol 543 assaultrifle 519 submachinegun 500 rifle 268 lr_energyweapon 191 flingshot 550 aimedshot 312 burst 328 fullauto 464 bowspecialattack 345 lr_multipleweapon 1304 closecombatinitiative 226 physicalprowessinitiative 226 dodge 1388 evade 1496 duck 597 nanoac 280 mechanicalengineering 537 electricalengineering 554 fieldquantumphysics 420 weaponsmithing 641 biologicalmetamorphose 570 psychologicalmodification 613 materialcreation 1631 materiallocation 1613 nanoprowessinitiative 539 shotgun 50 distanceweaponinitiative 281 computerliteracy 1568 nanoenergypool 850 martialarts 193 brawl 272 riposte 266 dimach 214 adventuring 425 swim 501 onehandbluntweapons 278 onehandedgedweapon 282 maxncu 91 fatness 1 race 1 accountflags 1234567890 monsterdata 0 VisualFlags 31 currentmovementmode 3 clan 0 healdelta 155 nanodelta 112 procnano1 210941 procinitiative1 4 procchance1 17 team 0 meleeac 1000 projectileac 1250 energyac 1500 fireac 1956 coldac 1933 radiationac 2183 chemicalac 1683 poisonac 1250 dmsmodifier 343 amsmodifier 21 rangeincreaserweapon 7 rangeincreasernf 31 firedamagemodifier 19 poisondamagemodifier 19 projectiledamagemodifier 19 radiationdamagemodifier 19 chemicaldamagemodifier 19 xpmodifier 9 npcostmodifier -8 skilllockmodifier -25 interruptmodifier -25 aggdef 100 state 0 unarmedtemplateinstance 0 invaderskilled 0 killedbyinvaders 0 vp 0 unsavedxp 0 nanofocuslevel 0 shadowbreedtemplate 0 shadowbreed 0 lastperkresettime 0 socialstatus 0 playeroptions 0 tempsaveteamid 0 tempsaveplayfield 0 tempsavex 0 tempsavey 0 PVPDuelKills 0 PVPDuelDeaths 0 PVPProfessionDuelKills 0 PVPProfessionDuelDeaths 0 PVPRankedSoloKills 0 PVPRankedSoloDeaths 0 PVPRankedTeamKills 0 PVPRankedTeamDeaths 0 PVPSoloScore 0 PVPTeamScore 0 PVPDuelScore 0 unreadmailcount 0 lastmailchecktime 1283065897 savedxp 0 features 6 apartmentsallowed 1 apartmentsowned 0 lastconcreteplayfieldinstance 0 mapoptions 0 mapareapart1 0 mapareapart2 0 mapareapart3 0 mapareapart4 0 missionbits1 0 missionbits2 0 missionbits3 0 missionbits4 0 missionbits5 0 missionbits6 0 missionbits7 0 missionbits8 0 missionbits9 0 missionbits10 0 missionbits11 0 missionbits12 0 sessiontime 1234567890 autoattackflags 5 personalresearchlevel 0 globalresearchlevel 0 personalresearchgoal 0 globalresearchgoal 0 battlestationside 0 battlestationrep 10 members 999 veteranpoints 0 monthspaid 0 PaidPoints 0 xpkillrange 5 inplay 0 attitude 0 alignment 0 icon 0 mesh 17530 deadtimer 0 lastsavexp 0 currentmass 0 itemtype 0 previoushealth 50 currentstate 0 age 0 attackspeed 5 metatype 0 rp 0 specialcondition 1 sk 0 clanredeemed 0 clanconserver 0 clandevoted 0 otunredeemed 0 otoperator 0 otfollowers 0 gos 0 clanvanguards 0 ottrans 0 clangaia 0 otmed 1234567890 clansentinels 0 otarmedforces 0 playerid 1234567890 alienlevel 0 aliennextxp 1500 alienxp 0 insurancepercentage 0 prevmovementmode 3 teamside 0 beltslots 0 absorbprojectileac 0 absorbmeleeac 0 absorbenergyac 0 absorbchemicalac 0 absorbradiationac 0 absorbcoldac 0 absorbnanoac 0 absorbfireac 0 absorbpoisonac 0 temporaryskillreduction 0 insurancetime 0 mapflags 0 changesidecount 0 healinterval 1 nanointerval 24 ------------------------------------ .getfull succeeded - Listed all stats for Raggy. ```
TheTinkeringIdiot commented 2024-01-31 01:24:14 +00:00 (Migrated from github.com)
Copy link

Confirmed.

The client reports that a piece of equipment is over-equipped at appropriate breakpoints, but server values for parameters related to that equipment do not change to reflect the reduced effectivity. It appears that OE rules are not enforced by the server.

Confirmed. The client reports that a piece of equipment is over-equipped at appropriate breakpoints, but server values for parameters related to that equipment do not change to reflect the reduced effectivity. It appears that OE rules are not enforced by the server.
portalerprk commented 2024-02-17 00:09:23 +00:00 (Migrated from github.com)
Copy link

Should be fixed with project-rubika/engines#391

Should be fixed with project-rubika/engines#391
RaggyLP commented 2024-02-17 13:42:48 +00:00 (Migrated from github.com)
Copy link

OE Confirmed to be implemented now. However, in-zone update doesn't occur, OE check seems to only be on zone currently and doesn't update stats dynamically.

image

OE Confirmed to be implemented now. However, in-zone update doesn't occur, OE check seems to only be on zone currently and doesn't update stats dynamically. ![image](https://github.com/project-rubika/issues/assets/156821187/b2c44c22-ca48-474a-bf78-a7114fce8a1d)
portalerprk commented 2024-02-17 16:43:51 +00:00 (Migrated from github.com)
Copy link

Could you explain a little more what you mean by "in-zone update"? It should recalculate the OE stats whenever a nano enters/exits NCU, or when items are equip/unequip etc. It's part of what we call RecalculateModifiers.

If you mean you manually adjust stats using .set <stat> <value> I dont think that triggers recalculation but thats sort of expected.

Could you explain a little more what you mean by "in-zone update"? It should recalculate the OE stats whenever a nano enters/exits NCU, or when items are equip/unequip etc. It's part of what we call `RecalculateModifiers`. If you mean you manually adjust stats using `.set <stat> <value>` I dont think that triggers recalculation but thats sort of expected.
RaggyLP commented 2024-02-17 16:55:54 +00:00 (Migrated from github.com)
Copy link

Could you explain a little more what you mean by "in-zone update"? It should recalculate the OE stats whenever a nano enters/exits NCU, or when items are equip/unequip etc. It's part of what we call RecalculateModifiers.

If you mean you manually adjust stats using .set <stat> <value> I dont think that triggers recalculation but thats sort of expected.

Aha, something I wasn't actually aware of. Thinking on it, that makes sense considering the only situations where there is going to be a stat change is in those two circumstances (excluding something like Towers dying/Org contracts). Retested by casting a nano to force the RecalculateModifiers call and confirmed as fully implemented.

Confirmed fixed as of UTC 16:55 - 17/02/24

> Could you explain a little more what you mean by "in-zone update"? It should recalculate the OE stats whenever a nano enters/exits NCU, or when items are equip/unequip etc. It's part of what we call `RecalculateModifiers`. > > If you mean you manually adjust stats using `.set <stat> <value>` I dont think that triggers recalculation but thats sort of expected. Aha, something I wasn't actually aware of. Thinking on it, that makes sense considering the only situations where there is going to be a stat change is in those two circumstances (excluding something like Towers dying/Org contracts). Retested by casting a nano to force the ```RecalculateModifiers``` call and confirmed as fully implemented. Confirmed fixed as of UTC 16:55 - 17/02/24
👍 1
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
470-items-duplicate-during-trade
No results found.
Labels
Clear labels   
area
blabot
Related to NPC dialog/conversations

  
area
client
This issue is (or appears to be) client-side

  
area
encounters
Related to scripted encounters

  
area
launcher
Related to the launcher

  
area
missions
Related to randomly generated missions

  
area
npc-behavior
Related to NPC/monster behaviour

  
area
performance
Caused by or related to server performance issues

  
area
portal
Related to the player portal website

  
area
quests
Issues relating to quests

  
area
rdb
Caused by RDB issues

  
area
teams
Issues relating to teaming with other players

  
area
trading
Related to trading with vendors and/or other players

  
area
zone

  
priority
1
Crashes playfield/server/other players or is game-breaking in a major way

  
priority
2
Crashes/breaks a character, significant gameplay impact with no workaround

  
priority
3
Standard or significant gameplay impact with workaround

  
priority
4
Trivial or minor gameplay impact, with or without workaround, or visual only

  
shadowlands

Related only to Shadowlands content

  
state
cant-reproduce
Can't be recreated by another tester

  
state
duplicate
This issue or pull request already exists

  
state
fixed
Developer has rolled out changes, needs re-tested to confirm fixed

  
state
new
Needs to be (re-)tested to ensure the issue is reproducible

  
state
unrefined
Needs more detail, repro steps or to be cleaned up

  
state
verified

  
state
wontfix
This will not be worked on

  
type
bug
An implemented feature is not working correctly

  
type
enhancement
Unimplemented feature, new feature / request

No labels
area
blabot
area
client
area
encounters
area
launcher
area
missions
area
npc-behavior
area
performance
area
portal
area
quests
area
rdb
area
teams
area
trading
area
zone
priority
1
priority
2
priority
3
priority
4
shadowlands
state
cant-reproduce
state
duplicate
state
fixed
state
new
state
unrefined
state
verified
state
wontfix
type
bug
type
enhancement
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: prk/issues#584
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?