prk/issues
20
3
Fork 0
Code Issues 243 Pull requests Projects 2 Releases Packages Wiki Activity Actions

Charm nanos allow overwrite #590

New issue
Closed
opened 2024-02-01 03:16:54 +00:00 by TheTinkeringIdiot · 1 comment
TheTinkeringIdiot commented 2024-02-01 03:16:54 +00:00 (Migrated from github.com)
Copy link

Describe the bug
Charm nanos are allowed to overwrite existing charms already running on a target. Doing so causes the casting animation to get stuck, and the player can no longer cast nanos until zoning. A "successful" overwrite attempt cancels the running charm nano but does not apply the new one.

This may be related to #589 since on live one of the checks when casting a charm is whether a charmed pet already exists, and failures are met with a "You already have a psychosis pet" message. Since charmed targets do not yet become pets on PRK they do not become friendly and so an attempt to overwrite charms can be made.

Regardless, charms should not be allowed to overwrite each other, or should do so without locking casting.

To Reproduce
Steps to reproduce the behavior:

  1. Select hostile or neutral target
  2. Cast charm nano
  3. Let the nano land successfully
  4. Cast the same or different charm nano on the same target
  5. The casting bar fills but never completes, and the character continues the casting animation indefinitely
  6. Nanos are locked as it a cast is taking place.

Expected behavior
Charm nanos should block attempts to overwrite, or should successfully overwrite completely.

**Describe the bug** Charm nanos are allowed to overwrite existing charms already running on a target. Doing so causes the casting animation to get stuck, and the player can no longer cast nanos until zoning. A "successful" overwrite attempt cancels the running charm nano but does not apply the new one. This may be related to #589 since on live one of the checks when casting a charm is whether a charmed pet already exists, and failures are met with a "You already have a psychosis pet" message. Since charmed targets do not yet become pets on PRK they do not become friendly and so an attempt to overwrite charms can be made. Regardless, charms should not be allowed to overwrite each other, or should do so without locking casting. **To Reproduce** Steps to reproduce the behavior: 1. Select hostile or neutral target 2. Cast charm nano 3. Let the nano land successfully 4. Cast the same or different charm nano on the same target 5. The casting bar fills but never completes, and the character continues the casting animation indefinitely 6. Nanos are locked as it a cast is taking place. **Expected behavior** Charm nanos should block attempts to overwrite, or should successfully overwrite completely.
TheTinkeringIdiot commented 2024-02-17 14:04:57 +00:00 (Migrated from github.com)
Copy link

Confirmed fixed. The charmed target correctly becomes friendly and attempts to overwrite the charm nano fail on that basis.

Confirmed fixed. The charmed target correctly becomes friendly and attempts to overwrite the charm nano fail on that basis.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
470-items-duplicate-during-trade
No results found.
Labels
Clear labels   
area
blabot
Related to NPC dialog/conversations

  
area
client
This issue is (or appears to be) client-side

  
area
encounters
Related to scripted encounters

  
area
launcher
Related to the launcher

  
area
missions
Related to randomly generated missions

  
area
npc-behavior
Related to NPC/monster behaviour

  
area
performance
Caused by or related to server performance issues

  
area
portal
Related to the player portal website

  
area
quests
Issues relating to quests

  
area
rdb
Caused by RDB issues

  
area
teams
Issues relating to teaming with other players

  
area
trading
Related to trading with vendors and/or other players

  
area
zone

  
priority
1
Crashes playfield/server/other players or is game-breaking in a major way

  
priority
2
Crashes/breaks a character, significant gameplay impact with no workaround

  
priority
3
Standard or significant gameplay impact with workaround

  
priority
4
Trivial or minor gameplay impact, with or without workaround, or visual only

  
shadowlands

Related only to Shadowlands content

  
state
cant-reproduce
Can't be recreated by another tester

  
state
duplicate
This issue or pull request already exists

  
state
fixed
Developer has rolled out changes, needs re-tested to confirm fixed

  
state
new
Needs to be (re-)tested to ensure the issue is reproducible

  
state
unrefined
Needs more detail, repro steps or to be cleaned up

  
state
verified

  
state
wontfix
This will not be worked on

  
type
bug
An implemented feature is not working correctly

  
type
enhancement
Unimplemented feature, new feature / request

No labels
area
blabot
area
client
area
encounters
area
launcher
area
missions
area
npc-behavior
area
performance
area
portal
area
quests
area
rdb
area
teams
area
trading
area
zone
priority
1
priority
2
priority
3
priority
4
shadowlands
state
cant-reproduce
state
duplicate
state
fixed
state
new
state
unrefined
state
verified
state
wontfix
type
bug
type
enhancement
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: prk/issues#590
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?