Charm nanos allow overwrite #590

Closed
opened 2024-02-01 04:16:54 +01:00 by TheTinkeringIdiot · 1 comment
TheTinkeringIdiot commented 2024-02-01 04:16:54 +01:00 (Migrated from github.com)

Describe the bug
Charm nanos are allowed to overwrite existing charms already running on a target. Doing so causes the casting animation to get stuck, and the player can no longer cast nanos until zoning. A "successful" overwrite attempt cancels the running charm nano but does not apply the new one.

This may be related to #589 since on live one of the checks when casting a charm is whether a charmed pet already exists, and failures are met with a "You already have a psychosis pet" message. Since charmed targets do not yet become pets on PRK they do not become friendly and so an attempt to overwrite charms can be made.

Regardless, charms should not be allowed to overwrite each other, or should do so without locking casting.

To Reproduce
Steps to reproduce the behavior:

  1. Select hostile or neutral target
  2. Cast charm nano
  3. Let the nano land successfully
  4. Cast the same or different charm nano on the same target
  5. The casting bar fills but never completes, and the character continues the casting animation indefinitely
  6. Nanos are locked as it a cast is taking place.

Expected behavior
Charm nanos should block attempts to overwrite, or should successfully overwrite completely.

**Describe the bug** Charm nanos are allowed to overwrite existing charms already running on a target. Doing so causes the casting animation to get stuck, and the player can no longer cast nanos until zoning. A "successful" overwrite attempt cancels the running charm nano but does not apply the new one. This may be related to #589 since on live one of the checks when casting a charm is whether a charmed pet already exists, and failures are met with a "You already have a psychosis pet" message. Since charmed targets do not yet become pets on PRK they do not become friendly and so an attempt to overwrite charms can be made. Regardless, charms should not be allowed to overwrite each other, or should do so without locking casting. **To Reproduce** Steps to reproduce the behavior: 1. Select hostile or neutral target 2. Cast charm nano 3. Let the nano land successfully 4. Cast the same or different charm nano on the same target 5. The casting bar fills but never completes, and the character continues the casting animation indefinitely 6. Nanos are locked as it a cast is taking place. **Expected behavior** Charm nanos should block attempts to overwrite, or should successfully overwrite completely.
TheTinkeringIdiot commented 2024-02-17 15:04:57 +01:00 (Migrated from github.com)

Confirmed fixed. The charmed target correctly becomes friendly and attempts to overwrite the charm nano fail on that basis.

Confirmed fixed. The charmed target correctly becomes friendly and attempts to overwrite the charm nano fail on that basis.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: prk/issues#590
No description provided.