prk/issues
19
3
Fork 0
Code Issues 239 Pull requests Projects 2 Releases Packages Wiki Activity Actions

Looted Credits are duplicated visually on the client. #636

New issue
Closed
opened 2024-02-24 22:09:11 +00:00 by RaggyLP · 2 comments
RaggyLP commented 2024-02-24 22:09:11 +00:00 (Migrated from github.com)
Copy link

Describe the bug
When looting a mob, any credits the corpse holds are being incorrectly doubled visually for the clients CRED value. The amount sent to the server is correct, however the client is updated at 2x the value.

To Reproduce
Steps to reproduce the behavior:

  1. Kill a mob
  2. Do .getfull cash on yourself.
  3. Note the number output and compare it to your clients listed value.
  4. Loot the mob
  5. Do another .getfull cash on yourself.
  6. Note that the value increase on the client is 2x what it should be.

Expected behavior
Cred amounts send to the client shouldn't be doubled and should accruate reflect the value held on the server.

Screenshots
image

**Describe the bug** When looting a mob, any credits the corpse holds are being incorrectly doubled visually for the clients CRED value. The amount sent to the server is correct, however the client is updated at 2x the value. **To Reproduce** Steps to reproduce the behavior: 1. Kill a mob 2. Do ```.getfull cash``` on yourself. 3. Note the number output and compare it to your clients listed value. 4. Loot the mob 5. Do another ```.getfull cash``` on yourself. 6. Note that the value increase on the client is 2x what it should be. **Expected behavior** Cred amounts send to the client shouldn't be doubled and should accruate reflect the value held on the server. **Screenshots** ![image](https://github.com/project-rubika/issues/assets/156821187/b2d4aee4-68bf-4518-82b3-2536effbcab6)
TheTinkeringIdiot commented 2024-02-26 02:06:23 +00:00 (Migrated from github.com)
Copy link

Confirmed. With a credit balance of 0, I killed a mob and looted 5 credits from it. /get cash on self correctly reports that I now have 5 credits. However the UI balance shows that I have 10 credits.

image

Confirmed. With a credit balance of 0, I killed a mob and looted 5 credits from it. `/get cash` on self correctly reports that I now have 5 credits. However the UI balance shows that I have 10 credits. ![image](https://github.com/project-rubika/issues/assets/96996793/ee8ec917-7487-4e94-abe3-0dceb034db14)
RaggyLP commented 2024-02-26 22:11:33 +00:00 (Migrated from github.com)
Copy link

The client now recieves the correct value when Creds are looted. Confirmed fixed as of 22:11 UTC - 26/02/24

image
image

The client now recieves the correct value when Creds are looted. Confirmed fixed as of 22:11 UTC - 26/02/24 ![image](https://github.com/project-rubika/issues/assets/156821187/89ff5ba9-f6fd-40a6-bdb6-7b5221cf8c24) ![image](https://github.com/project-rubika/issues/assets/156821187/01fbf859-eb2e-4df8-98a1-8d75466ac5fb)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
470-items-duplicate-during-trade
No results found.
Labels
Clear labels   
area
blabot
Related to NPC dialog/conversations

  
area
client
This issue is (or appears to be) client-side

  
area
encounters
Related to scripted encounters

  
area
launcher
Related to the launcher

  
area
missions
Related to randomly generated missions

  
area
npc-behavior
Related to NPC/monster behaviour

  
area
performance
Caused by or related to server performance issues

  
area
portal
Related to the player portal website

  
area
quests
Issues relating to quests

  
area
rdb
Caused by RDB issues

  
area
teams
Issues relating to teaming with other players

  
area
trading
Related to trading with vendors and/or other players

  
area
zone

  
priority
1
Crashes playfield/server/other players or is game-breaking in a major way

  
priority
2
Crashes/breaks a character, significant gameplay impact with no workaround

  
priority
3
Standard or significant gameplay impact with workaround

  
priority
4
Trivial or minor gameplay impact, with or without workaround, or visual only

  
shadowlands

Related only to Shadowlands content

  
state
cant-reproduce
Can't be recreated by another tester

  
state
duplicate
This issue or pull request already exists

  
state
fixed
Developer has rolled out changes, needs re-tested to confirm fixed

  
state
new
Needs to be (re-)tested to ensure the issue is reproducible

  
state
unrefined
Needs more detail, repro steps or to be cleaned up

  
state
verified

  
state
wontfix
This will not be worked on

  
type
bug
An implemented feature is not working correctly

  
type
enhancement
Unimplemented feature, new feature / request

No labels
area
blabot
area
client
area
encounters
area
launcher
area
missions
area
npc-behavior
area
performance
area
portal
area
quests
area
rdb
area
teams
area
trading
area
zone
priority
1
priority
2
priority
3
priority
4
shadowlands
state
cant-reproduce
state
duplicate
state
fixed
state
new
state
unrefined
state
verified
state
wontfix
type
bug
type
enhancement
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: prk/issues#636
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?