prk/issues
12
3
Fork 0
Code Issues 231 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Pets disappear when quickly zoning twice #725

New Issue
Closed
opened 2024-04-12 00:40:35 +02:00 by JulianVallee · 3 comments
JulianVallee commented 2024-04-12 00:40:35 +02:00 (Migrated from github.com)
Copy Link

Describe the bug
Pets are not properly reassigned when quickly zoning twice in a row.

When the second zoning before the pet gets reassigned after the first zoning, there is no pet left to reassign. Not sure about the architecture, but could be a potential memory leak imo.

To Reproduce
Steps to reproduce the behavior:

  1. Summon a pet
  2. Zone to somewhere else
  3. Zone back again before the pet spawns (1-3 secs leeway, Pet XXX reassigned. should not be printed to chat)
  4. Pet is gone

Expected behavior
Pets should not disappear and reassigning should happen correctly.

**Describe the bug** Pets are not properly reassigned when quickly zoning twice in a row. When the second zoning before the pet gets reassigned after the first zoning, there is no pet left to reassign. Not sure about the architecture, but could be a potential memory leak imo. **To Reproduce** Steps to reproduce the behavior: 1. Summon a pet 2. Zone to somewhere else 3. Zone back again before the pet spawns (1-3 secs leeway, `Pet XXX reassigned.` should not be printed to chat) 4. Pet is gone **Expected behavior** Pets should not disappear and reassigning should happen correctly.
RaggyLP commented 2024-04-15 23:43:34 +02:00 (Migrated from github.com)
Copy Link

Confirmed, zoning in the manner described above will remove the pet from the character and not assign a new entity.

Confirmed, zoning in the manner described above will remove the pet from the character and not assign a new entity.
Unknownprk commented 2024-06-28 00:12:40 +02:00 (Migrated from github.com)
Copy Link

Potentially fixed now

Potentially fixed now
❤️ 1
RaggyLP commented 2024-06-30 13:38:31 +02:00 (Migrated from github.com)
Copy Link

Re-tested using the 3 main pet classes, this now appears to be fixed! Closing as fixed as of 30/06/24.

Re-tested using the 3 main pet classes, this now appears to be fixed! Closing as fixed as of 30/06/24.
❤️ 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area
blabot
Related to NPC dialog/conversations
area
client
This issue is (or appears to be) client-side
area
encounters
Related to scripted encounters
area
launcher
Related to the launcher
area
missions
Related to randomly generated missions
area
npc-behavior
Related to NPC/monster behaviour
area
performance
Caused by or related to server performance issues
area
portal
Related to the player portal website
area
quests
Issues relating to quests
area
rdb
Caused by RDB issues
area
teams
Issues relating to teaming with other players
area
trading
Related to trading with vendors and/or other players
priority
1
Crashes playfield/server/other players or is game-breaking in a major way
priority
2
Crashes/breaks a character, significant gameplay impact with no workaround
priority
3
Standard or significant gameplay impact with workaround
priority
4
Trivial or minor gameplay impact, with or without workaround, or visual only
shadowlands
Related only to Shadowlands content
state
cant-reproduce
Can't be recreated by another tester
state
duplicate
This issue or pull request already exists
state
fixed
Developer has rolled out changes, needs re-tested to confirm fixed
state
new
Needs to be (re-)tested to ensure the issue is reproducible
state
unrefined
Needs more detail, repro steps or to be cleaned up
state
wontfix
This will not be worked on
type
bug
An implemented feature is not working correctly
type
enhancement
Unimplemented feature, new feature / request
No Label
priority
2
state
fixed
type
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3f1 drake GlitchyGirl kajori madcow mazeeq2 portaler prk-system Raggy TinkeringIdiot Unknown
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: prk/issues#725
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?