prk/issues
8
1
Fork 0
Code Issues 249 Pull Requests Actions Packages Projects Releases Wiki Activity

"Disable all XP gains" option not working #785

New Issue
Closed
opened 2024-08-22 03:42:01 +02:00 by Dezzyx · 6 comments
Dezzyx commented 2024-08-22 03:42:01 +02:00 (Migrated from github.com)
Copy Link

Describe the bug

The "Disable all XP gains" preference is not saved on relogg.

More importantly, the function itself does not work at all, even if you see it ticked on. Furthermore your XP bar value may show no change, but once you relogg the XP you gained with Disable XP on is now added.

To Reproduce

  1. Go to Preferences > Tick Disable all XP gains
  2. Kill a mob for XP
  3. See your XP bar increase. If not relog and see the updated XP.

Expected behavior

With Disable all XP gains on, no XP should be gained. Your preference for the setting (on/off) should also be saved, and not
revert on relogging.

Describe the bug The "Disable all XP gains" preference is not saved on relogg. More importantly, the function itself does not work at all, even if you see it ticked on. Furthermore your XP bar value may show no change, but once you relogg the XP you gained with Disable XP on is now added. To Reproduce 1. Go to Preferences > Tick Disable all XP gains 2. Kill a mob for XP 3. See your XP bar increase. If not relog and see the updated XP. Expected behavior With Disable all XP gains on, no XP should be gained. Your preference for the setting (on/off) should also be saved, and not revert on relogging.
prkdrake commented 2024-08-24 22:40:49 +02:00 (Migrated from github.com)
Copy Link

This feature will be implemented as of the next update.

This feature will be implemented as of the next update.
RaggyLP commented 2024-08-25 00:06:25 +02:00 (Migrated from github.com)
Copy Link

Confirmed. XP is now disabled via the checkbox in the F10 settings menu and retains the tick across zoning. However, XP gained is not sent to the players xppool value, like it is on live. This includes any XP gained from quest rewards.

Confirmed. XP is now disabled via the checkbox in the F10 settings menu and retains the tick across zoning. However, XP gained is not sent to the players xppool value, like it is on live. This includes any XP gained from quest rewards.
prkdrake commented 2024-08-25 01:52:32 +02:00 (Migrated from github.com)
Copy Link

XP gains should be going into the pool

XP gains should be going into the pool
RaggyLP commented 2024-08-25 01:54:39 +02:00 (Migrated from github.com)
Copy Link

Indeed, they are. Using .get xppool before and after a kill confirms this. Just missing the messaging to confirm that this process is occurring.

Indeed, they are. Using `.get xppool` before and after a kill confirms this. Just missing the messaging to confirm that this process is occurring.
prkdrake commented 2024-08-25 17:54:58 +02:00 (Migrated from github.com)
Copy Link

Should be fixed with the latest update

Should be fixed with the latest update
RaggyLP commented 2024-08-25 19:56:56 +02:00 (Migrated from github.com)
Copy Link

image

Confirmed, Disable XP Gains is now working excatly as expected. Great job! Closing as fixed as of 25/08/2024.

![image](https://github.com/user-attachments/assets/ecc95435-8642-4be1-bf34-bfbe5dcdde96) Confirmed, Disable XP Gains is now working excatly as expected. Great job! Closing as fixed as of 25/08/2024.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
area
blabot
Related to NPC dialog/conversations

  
area
client
This issue is (or appears to be) client-side

  
area
encounters
Related to scripted encounters

  
area
launcher
Related to the launcher

  
area
missions
Related to randomly generated missions

  
area
npc-behavior
Related to NPC/monster behaviour

  
area
performance
Caused by or related to server performance issues

  
area
portal
Related to the player portal website

  
area
rdb
Caused by RDB issues

  
priority
1
Crashes playfield/server/other players or is game-breaking in a major way

  
priority
2
Crashes/breaks a character, significant gameplay impact with no workaround

  
priority
3
Standard or significant gameplay impact with workaround

  
priority
4
Trivial or minor gameplay impact, with or without workaround, or visual only

  
shadowlands

Related only to Shadowlands content

  
state
cant-reproduce
Can't be recreated by another tester

  
state
duplicate
This issue or pull request already exists

  
state
fixed
Developer has rolled out changes, needs re-tested to confirm fixed

  
state
new
Needs to be (re-)tested to ensure the issue is reproducible

  
state
unrefined
Needs more detail, repro steps or to be cleaned up

  
state
wontfix
This will not be worked on

  
type
bug
An implemented feature is not working correctly

  
type
enhancement
Unimplemented feature, new feature / request

No Label
area
blabot
area
client
area
encounters
area
launcher
area
missions
area
npc-behavior
area
performance
area
portal
area
rdb
priority
1
priority
2
priority
3
priority
4
shadowlands
state
cant-reproduce
state
duplicate
state
fixed
state
new
state
unrefined
state
wontfix
type
bug
type
enhancement
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: prk/issues#785
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?