Updates to weapon templates whilst in combat are not applied to damage. #845

New Issue

Raggy · 2024-09-04T21:41:38+02:00

RaggyLP commented

2024-09-04 21:41:38 +02:00

(Migrated from github.com)

Describe the bug
For weapon templates that have a malleable damage profile, or, if playing a profession that has access in-combat skill increases such as drains or short-term buffs, the updated skill figure is not reflected in the output of the weapon. And example of this would be using a drain and the MA template changing from QL74 to QL77, this should result in an immediate change in the damage output of the weapon, however, this only occurs if the player cycles combat stance with Q > Q, suggesting the template is snapshotted upon entering that stance. This appears to only affect the weapon template, any +dmg buffs on the player are accurately reflected.

To Reproduce
Steps to reproduce the behavior:

Make a Trader, set MA skill to about 150 and 100% crit for ease of testing. .set martialarts 150 .set criticalincrease 300
Find a target and give it a large sum of health to do an extended combat test. .set life 99999999 .set health 99999999
Enter combat and note the damage you are dealing, do .weapon now hit the target with a Drain.
Do .weapon again, note the change in MA weapon QL and how the damage profile does not update to reflect the change in weapon.

Expected behavior
Weapon damage should be dynamically updated to reflect changes in skill/AR

Screenshots

After stopping and starting combat:

**Describe the bug** For weapon templates that have a malleable damage profile, or, if playing a profession that has access in-combat skill increases such as drains or short-term buffs, the updated skill figure is not reflected in the output of the weapon. And example of this would be using a drain and the MA template changing from QL74 to QL77, this should result in an immediate change in the damage output of the weapon, however, this only occurs if the player cycles combat stance with Q > Q, suggesting the template is snapshotted upon entering that stance. This appears to only affect the weapon template, any +dmg buffs on the player are accurately reflected. **To Reproduce** Steps to reproduce the behavior: 1. Make a Trader, set MA skill to about 150 and 100% crit for ease of testing. `.set martialarts 150` `.set criticalincrease 300` 2. Find a target and give it a large sum of health to do an extended combat test. `.set life 99999999` `.set health 99999999` 3. Enter combat and note the damage you are dealing, do `.weapon` now hit the target with a Drain. 4. Do `.weapon` again, note the change in MA weapon QL and how the damage profile does not update to reflect the change in weapon. **Expected behavior** Weapon damage should be dynamically updated to reflect changes in skill/AR **Screenshots** ![image](https://github.com/user-attachments/assets/de217e26-8e14-4876-a61b-aaf57e904426) After stopping and starting combat: ![image](https://github.com/user-attachments/assets/c76e32ed-cf64-4cb6-80d8-0be37bd07d1c)

RaggyLP commented

2024-09-10 23:09:19 +02:00

(Migrated from github.com)

Retested following internal changes applied by the Absorbs fixes in #873. Confirmed that it is now solved. Closing as fixed as of 10/09/2024.

Raggy commented

2024-10-03 00:48:05 +02:00

This appears to have returned. Using MA and increasing MA skill mid combat doesn't result in an update to damage from template change until you cycle combat.

Raggy reopened this issue

2024-10-03 01:04:06 +02:00

Raggy commented

2024-10-03 01:28:10 +02:00

Disregard, further testing shows the fix is still in play.

Raggy closed this issue

2024-10-03 01:28:10 +02:00

Sign in to join this conversation.

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: prk/issues#845