Looting a stackable item you already have a stack of does not merge the stacks server-side #872

New Issue

Raggy · 2024-09-09T16:14:58+02:00

7RO11 commented

2024-09-09 16:14:58 +02:00

(Migrated from github.com)

Describe the bug
items that can stack will appear to stack when looted off a corpse, but don't

To Reproduce
Steps to reproduce the behavior:

Go to subway
kill and loot some stim fiends until you find stims of the same level
loot the stims of the same level, they will appear to stack with the ones in your inventory
you won't be able to fill an inventory slot now

Expected behavior
the items should either not stack or stack when looted

Screenshots
a situation like this, level 10 nano stims in inventory and on a corpse

looting it will make it stack

but when you try to loot something else with 1 inventory slot left, it won't let you

the stims will unstack on zone or relog

i have noticed the same behavior with ammo drops in the subway

this doesn't happen with other methods of adding items, shops, mission rewards, .item

**Describe the bug** items that can stack will appear to stack when looted off a corpse, but don't **To Reproduce** Steps to reproduce the behavior: 1. Go to subway 2. kill and loot some stim fiends until you find stims of the same level 3. loot the stims of the same level, they will appear to stack with the ones in your inventory 4. you won't be able to fill an inventory slot now **Expected behavior** the items should either not stack or stack when looted **Screenshots** a situation like this, level 10 nano stims in inventory and on a corpse ![Screenshot from 2024-09-09 09-27-34](https://github.com/user-attachments/assets/ae037c56-b1d6-4998-b932-d04f737be380) ![Screenshot from 2024-09-09 09-27-50](https://github.com/user-attachments/assets/491d351b-4dde-475d-8d5c-17ab6ff9ec56) looting it will make it stack ![Screenshot from 2024-09-09 09-28-10](https://github.com/user-attachments/assets/af77ceb0-0e99-4223-bc9d-ddb8a160e27f) but when you try to loot something else with 1 inventory slot left, it won't let you ![Screenshot from 2024-09-09 09-30-02](https://github.com/user-attachments/assets/dcd426ee-6973-42d9-97c2-9f49783549b6) the stims will unstack on zone or relog i have noticed the same behavior with ammo drops in the subway this doesn't happen with other methods of adding items, shops, mission rewards, .item ----

kajoriEU commented

2024-09-09 17:13:46 +02:00

(Migrated from github.com)

Confirmed. I am able to reproduce this issue as described above. On second relog it was staying in its correct stack.

First relog after looting stims from Stim Fiend:

https://github.com/user-attachments/assets/31399e14-c153-4670-bf52-0af7ce92a9b3

Second relog with the same items that got unstacked from the first relog:

https://github.com/user-attachments/assets/a70837d2-3c68-4f62-b5cb-3a0bbf0ae3e6

Confirmed. I am able to reproduce this issue as described above. On second relog it was staying in its correct stack. First relog after looting stims from Stim Fiend: https://github.com/user-attachments/assets/31399e14-c153-4670-bf52-0af7ce92a9b3 Second relog with the same items that got unstacked from the first relog: https://github.com/user-attachments/assets/a70837d2-3c68-4f62-b5cb-3a0bbf0ae3e6

Raggy commented

2024-10-16 11:44:07 +02:00

Raising the priority on this one as further testing has highlighted that if certain conditions are met, unequippable items can be placed on the wear window. Repro instructions in BH chat.

Raggy added

and removed

labels 2024-10-16 11:44:30 +02:00

kristianaabakken commented

2024-10-17 12:50:03 +02:00

https://bytebin.project-rk.com/0aGAjrkK

I dont know how it happened, and cant repoduce it, but it happened either when i tried to use the Spirit Siphon, or looted it in ELY port 7.

Issue:
Spirit Siphon got equiped in implantslot Legs, and i cant remove it.
By right clicking a spirit i get message: Target slot is not empty.
By trying to use it (to get rid of the stack):

On mobs; (Unknown entity used: ImplantPage:0000002B)
When i target myself: You can't attack yourself.

https://bytebin.project-rk.com/0aGAjrkK I dont know how it happened, and cant repoduce it, but it happened either when i tried to use the Spirit Siphon, or looted it in ELY port 7. **Issue:** Spirit Siphon got equiped in implantslot Legs, and i cant remove it. By right clicking a spirit i get message: Target slot is not empty. By trying to use it (to get rid of the stack): - On mobs; (Unknown entity used: ImplantPage:0000002B) - When i target myself: You can't attack yourself.

Screenshot 2024-10-17 124958.png

126 KiB

drake changed title from ~~stacking items on loot~~ to Looting a stackable item you already have a stack of does not merge the stacks server-side

2024-10-17 13:39:21 +02:00

drake commented

2024-10-18 00:36:13 +02:00

I have implemented a partial fix for this, for now - I have prevented players from equipping items which they should not equip (e.g. bullets/stims/spirit siphons/etc.) which should prevent random junk from ending up in a character's equipment tabs. Once this fix is confirmed I will also fix it so that item stacks merge properly.

drake added the

state

fixed

label 2024-10-18 00:36:19 +02:00

Raggy commented

2024-10-18 00:46:10 +02:00

Confirmed that this is now fixed. The server now outputs a 'Sorry, you cannot equip this string.' when attempting to move items from the 'ghost' slot to the wear window.

Situation is ready for the further fix for false stacks on the client.

Confirmed that this is now fixed. The server now outputs a 'Sorry, you cannot equip this string.' when attempting to move items from the 'ghost' slot to the wear window. Situation is ready for the further fix for false stacks on the client.

Raggy removed the

state

fixed

label 2024-10-18 00:46:27 +02:00

kajori added this to the Season 2 Launch project 2024-11-25 16:25:19 +01:00

drake self-assigned this 2024-12-12 19:45:30 +01:00

drake added the

state

fixed

label 2024-12-20 14:04:07 +01:00

drake commented

2024-12-20 14:04:13 +01:00