Failed perk actions have non-descriptive errors #616

Closed
opened 2024-02-20 04:36:15 +01:00 by TheTinkeringIdiot · 2 comments
TheTinkeringIdiot commented 2024-02-20 04:36:15 +01:00 (Migrated from github.com)

Describe the bug
Perk actions that cannot fire due to missing dependencies do not provide uninterpolated format strings (Your %s is required to be at least %d) instead of helpful error messages.

To Reproduce
Steps to reproduce the behavior:

  1. Be MA or Enforcer
  2. Perk Brawler 6
  3. Attempt to use perk action Followup Smash on a target without using Big Smash first

Expected behavior
Error messages should list why the perk action is not firing

Screenshots
image

**Describe the bug** Perk actions that cannot fire due to missing dependencies do not provide uninterpolated format strings (`Your %s is required to be at least %d`) instead of helpful error messages. **To Reproduce** Steps to reproduce the behavior: 1. Be MA or Enforcer 2. Perk Brawler 6 3. Attempt to use perk action Followup Smash on a target without using Big Smash first **Expected behavior** Error messages should list why the perk action is not firing **Screenshots** ![image](https://github.com/project-rubika/issues/assets/96996793/899bf6c3-69f0-4a5a-83c1-c9eb00c1e3f6)
RaggyLP commented 2024-02-22 19:24:36 +01:00 (Migrated from github.com)

Confirmed through #517.

Confirmed through #517.
RaggyLP commented 2024-02-27 23:25:28 +01:00 (Migrated from github.com)

This has now been fixed, perk errors are now descriptive of their errors. Fixed as of 22:25 UTC - 27/02/24

image

This has now been fixed, perk errors are now descriptive of their errors. Fixed as of 22:25 UTC - 27/02/24 ![image](https://github.com/project-rubika/issues/assets/156821187/1a841cf6-af6b-4a97-8d56-4b2fdc76fc1c)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: prk/issues#616
No description provided.